Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enforce Stack queries when doing backup #1269

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Dec 20, 2024

When doing a backup, we don't want instable network to make the CozyClient use local PouchLink for some queries that need to read files paths

In cozy/cozy-client#1575 we implemented the forceStack option that allows to enforce the usage of StackLink instead of other links that may retrieve local incomplete data

This commit enforce the stack on backup related queries

Related PR: cozy/cozy-client#1575


TODO:

### ✨ Features

*

### 🐛 Bug Fixes

* Fix a bug that would display incorrect error message when trying to backup photos when no internet connection is available

### 🔧 Tech

*

@Ldoppea Ldoppea force-pushed the fix/prevent_offline_backup branch from a41d704 to d73c09d Compare December 20, 2024 17:33
@Ldoppea Ldoppea force-pushed the fix/prevent_offline_backup branch from d73c09d to cd700c0 Compare December 20, 2024 19:38
@Ldoppea Ldoppea force-pushed the fix/prevent_offline_backup branch from cd700c0 to a015a0b Compare December 20, 2024 19:55
@Ldoppea Ldoppea force-pushed the fix/prevent_offline_backup branch from a015a0b to 3a4ad93 Compare December 20, 2024 20:09
@Ldoppea Ldoppea force-pushed the fix/prevent_offline_backup branch from 3a4ad93 to cf951d0 Compare December 20, 2024 20:21
@Ldoppea Ldoppea force-pushed the fix/prevent_offline_backup branch from cf951d0 to 59d2c7d Compare January 9, 2025 10:51
Base automatically changed from feat/opsqlite to feat/meta_offline January 17, 2025 11:01
`cozy-client` and `cozy-pouch-link` has been upgraded to `52.0.0` in
order to retrieve the ability to enforce StackLink usage for a query

Related PR: cozy/cozy-client#1575
When doing a backup, we don't want instable network to make the
CozyClient use local PouchLink for some queries that need to read files
paths

In cozy/cozy-client#1575 we implemented the `forceStack` option that
allows to enforce the usage of StackLink instead of other links that
may retrieve local incomplete data

This commit enforce the stack on backup related queries

Related PR: cozy/cozy-client#1575
@Ldoppea Ldoppea force-pushed the fix/prevent_offline_backup branch from 59d2c7d to 3735581 Compare January 17, 2025 11:02
@Ldoppea Ldoppea merged commit 56beaad into feat/meta_offline Jan 17, 2025
1 check passed
@Ldoppea Ldoppea deleted the fix/prevent_offline_backup branch January 17, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant